Skip to content

Remove not in services cache#250

Merged
CodyCBakerPhD merged 4 commits into
mainfrom
no-services-cache
May 27, 2026
Merged

Remove not in services cache#250
CodyCBakerPhD merged 4 commits into
mainfrom
no-services-cache

Conversation

@CodyCBakerPhD
Copy link
Copy Markdown
Collaborator

closes #240

Co-Authored-By: Claude <noreply@anthropic.com>
@CodyCBakerPhD CodyCBakerPhD self-assigned this May 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

❌ Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.82%. Comparing base (5130621) to head (1e03256).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
..._extraction/ip_utils/_update_ip_to_region_codes.py 64.28% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   73.43%   71.82%   -1.62%     
==========================================
  Files          41       40       -1     
  Lines        1547     1494      -53     
==========================================
- Hits         1136     1073      -63     
- Misses        411      421      +10     
Flag Coverage Δ
unittests 71.82% <64.28%> (-1.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/s3_log_extraction/ip_utils/_ip_cache.py 100.00% <ø> (ø)
..._extraction/ip_utils/_update_ip_to_region_codes.py 83.01% <64.28%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CodyCBakerPhD CodyCBakerPhD merged commit 936ad05 into main May 27, 2026
5 of 6 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the no-services-cache branch May 27, 2026 23:03
@CodyCBakerPhD CodyCBakerPhD moved this to Uncategorized in My Work History May 28, 2026
@github-project-automation github-project-automation Bot moved this from Uncategorized to Done in My Work History May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do we still need the 'not in services' cache?

1 participant